Add USERNAME build argument#220
Merged
Conversation
nashif
approved these changes
Mar 7, 2025
Contributor
Author
|
Hmm.. I'm not sure how this is supposed to be merged. Since I don't have write access to this repo, I don't think I have any way to do it.. If someone who does have write permissions can do it, that would be great :) |
Member
|
Can you please rebase? |
Contributor
Author
|
Ok, I think I got it rebased correctly.. (this is my first time syncing a forked project, so take a close look) |
Member
|
please cleanup you commits, you should not have any merge commits. Fixes of your own changes should be squashed into the same commit introducing the change. |
Contributor
Author
|
Ok, squashed and rebased. |
nashif
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a USERNAME build argument so that the ssh-agents will work (they require the username inside the container to be the same as the user name that is running the ssh-agent. This is an optional argument so if they don't use it, it defaults to
useras before.I ran into a problem with getting the entrypoint.sh path to work with the ${USERNAME} variable so I just punted and put the entrypoint.sh in the
/userdirectory. If anyone knows how to get it to work, please speak up :)